Skip to content

regression: not allowing apps with default permissions to read settings #35388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 2 commits into from
Mar 3, 2025
Merged

regression: not allowing apps with default permissions to read settings #35388

kodiakhq merged 2 commits into from
Mar 3, 2025

Conversation

@Gustrb
Copy link
Contributor

@Gustrb Gustrb commented Mar 3, 2025 •
edited by atlassian bot
Loading

Proposed changes (including videos or screenshots)

Issue(s)

CONN-555

Steps to test or reproduce

Further comments

Introduced in: https://github.com/RocketChat/Rocket.Chat/pull/35199/files#diff-c48428c180d5e7580869c8c23cfa09514ef1428da2e29a252a4c2ed66a09590dR63-R67

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Mar 3, 2025 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: f688543

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@d-gubert d-gubert added this to the 7.4.0 milestone Mar 3, 2025
@codecov
Copy link

codecov bot commented Mar 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.46%. Comparing base (ef8a900) to head (f688543).
Report is 1 commits behind head on release-7.4.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.4.0   #35388   +/-   ##
==============================================
  Coverage          59.46%   59.46%           
==============================================
  Files               2830     2830           
  Lines              68627    68627           
  Branches           15181    15181           
==============================================
  Hits               40808    40808           
  Misses             25149    25149           
  Partials            2670     2670
Flag Coverage Δ
unit 75.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Gustrb Gustrb marked this pull request as ready for review March 3, 2025 18:06
@Gustrb Gustrb requested a review from a team as a code owner March 3, 2025 18:06
@Gustrb Gustrb added the stat: QA assured Means it has been tested and approved by a company insider label Mar 3, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 3, 2025
@kodiakhq kodiakhq bot merged commit c4109b9 into release-7.4.0 Mar 3, 2025
43 of 45 checks passed
@kodiakhq kodiakhq bot deleted the regression/apps-without-permission-list branch March 3, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d-gubert d-gubert d-gubert approved these changes

Assignees

No one assigned

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

7.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Gustrb @d-gubert